Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
cpu/x86/lapic_def.h: Drop unused macros
These macros are unused and rather confusing to use. Get rid of them.
Change-Id: I435411e46361dc62a40965b7fb77421a4212724a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/cpu/x86/lapic_def.h 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/42454/1
diff --git a/src/include/cpu/x86/lapic_def.h b/src/include/cpu/x86/lapic_def.h index 9da89ee..934c86c 100644 --- a/src/include/cpu/x86/lapic_def.h +++ b/src/include/cpu/x86/lapic_def.h @@ -52,14 +52,11 @@ #define LAPIC_DM_EXTINT 0x00700 #define LAPIC_VECTOR_MASK 0x000FF #define LAPIC_ICR2 0x310 -#define GET_LAPIC_DEST_FIELD(x) (((x)>>24)&0xFF) #define SET_LAPIC_DEST_FIELD(x) ((x)<<24) #define LAPIC_LVTT 0x320 #define LAPIC_LVTPC 0x340 #define LAPIC_LVT0 0x350 #define LAPIC_LVT_TIMER_BASE_MASK (0x3<<18) -#define GET_LAPIC_TIMER_BASE(x) (((x)>>18)&0x3) -#define SET_LAPIC_TIMER_BASE(x) (((x)<<18)) #define LAPIC_TIMER_BASE_CLKIN 0x0 #define LAPIC_TIMER_BASE_TMBASE 0x1 #define LAPIC_TIMER_BASE_DIV 0x2 @@ -74,8 +71,6 @@ #define LAPIC_DELIVERY_MODE_FIXED (0<<8) #define LAPIC_DELIVERY_MODE_NMI (4<<8) #define LAPIC_DELIVERY_MODE_EXTINT (7<<8) -#define GET_LAPIC_DELIVERY_MODE(x) (((x)>>8)&0x7) -#define SET_LAPIC_DELIVERY_MODE(x, y) (((x)&~0x700)|((y)<<8)) #define LAPIC_MODE_FIXED 0x0 #define LAPIC_MODE_NMI 0x4 #define LAPIC_MODE_EXINT 0x7
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... File src/include/cpu/x86/lapic_def.h:
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 55: SET_LAPIC_DEST_FIELD Before anyone asks, this one is used, so can't delete it right away...
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... File src/include/cpu/x86/lapic_def.h:
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 60: #define LAPIC_TIMER_BASE_CLKIN 0x0 : #define LAPIC_TIMER_BASE_TMBASE 0x1 : #define LAPIC_TIMER_BASE_DIV 0x2 after removing the macros these values are meant to be used with, these values become just wrong. adding the shift here would make them correct again
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 74: #define LAPIC_MODE_FIXED 0x0 : #define LAPIC_MODE_NMI 0x4 : #define LAPIC_MODE_EXINT 0x7 if you delete the macro using these values, you should also delete these values to avoid even more confusion. the defines that shift things to the right bit positions are above
Hello build bot (Jenkins), Nico Huber, Raul Rangel, Furquan Shaikh, Aaron Durbin, Felix Held, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42454
to look at the new patch set (#2).
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
cpu/x86/lapic_def.h: Drop unused macros
These macros are unused and rather confusing to use. Get rid of them.
Change-Id: I435411e46361dc62a40965b7fb77421a4212724a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/cpu/x86/lapic_def.h 1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/42454/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... File src/include/cpu/x86/lapic_def.h:
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 60: #define LAPIC_TIMER_BASE_CLKIN 0x0 : #define LAPIC_TIMER_BASE_TMBASE 0x1 : #define LAPIC_TIMER_BASE_DIV 0x2
after removing the macros these values are meant to be used with, these values become just wrong. […]
Done
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 74: #define LAPIC_MODE_FIXED 0x0 : #define LAPIC_MODE_NMI 0x4 : #define LAPIC_MODE_EXINT 0x7
if you delete the macro using these values, you should also delete these values to avoid even more c […]
Done
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Removed Verified+1 by build bot (Jenkins) no-reply@coreboot.org
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 3:
Why would you remove unused macros from "*.h" ?
you have many inhere : src/include/device/pci_ids.h :)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 3:
Patch Set 3:
Why would you remove unused macros from "*.h" ?
you have many inhere : src/include/device/pci_ids.h :)
Refer to the commit message.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Why would you remove unused macros from "*.h" ?
you have many inhere : src/include/device/pci_ids.h :)
Refer to the commit message.
Finally, I found the exact reason why I hate it: https://review.coreboot.org/c/coreboot/+/42434/1/src/cpu/x86/lapic/lapic.c#2...
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42454?usp=email )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Martin L Roth (Code Review)