Angel Pons has uploaded this change for review.

View Change

cpu/x86/lapic_def.h: Drop unused macros

These macros are unused and rather confusing to use. Get rid of them.

Change-Id: I435411e46361dc62a40965b7fb77421a4212724a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
---
M src/include/cpu/x86/lapic_def.h
1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/42454/1

diff --git a/src/include/cpu/x86/lapic_def.h b/src/include/cpu/x86/lapic_def.h
index 9da89ee..934c86c 100644
--- a/src/include/cpu/x86/lapic_def.h
+++ b/src/include/cpu/x86/lapic_def.h
@@ -52,14 +52,11 @@
 #define		LAPIC_DM_EXTINT		0x00700
 #define		LAPIC_VECTOR_MASK	0x000FF
 #define LAPIC_ICR2	0x310
-#define		GET_LAPIC_DEST_FIELD(x)	(((x)>>24)&0xFF)
 #define		SET_LAPIC_DEST_FIELD(x)	((x)<<24)
 #define LAPIC_LVTT	0x320
 #define LAPIC_LVTPC	0x340
 #define LAPIC_LVT0	0x350
 #define		LAPIC_LVT_TIMER_BASE_MASK	(0x3<<18)
-#define		GET_LAPIC_TIMER_BASE(x)		(((x)>>18)&0x3)
-#define		SET_LAPIC_TIMER_BASE(x)		(((x)<<18))
 #define		LAPIC_TIMER_BASE_CLKIN		0x0
 #define		LAPIC_TIMER_BASE_TMBASE		0x1
 #define		LAPIC_TIMER_BASE_DIV		0x2
@@ -74,8 +71,6 @@
 #define		LAPIC_DELIVERY_MODE_FIXED	(0<<8)
 #define		LAPIC_DELIVERY_MODE_NMI		(4<<8)
 #define		LAPIC_DELIVERY_MODE_EXTINT	(7<<8)
-#define		GET_LAPIC_DELIVERY_MODE(x)	(((x)>>8)&0x7)
-#define		SET_LAPIC_DELIVERY_MODE(x, y)	(((x)&~0x700)|((y)<<8))
 #define			LAPIC_MODE_FIXED		0x0
 #define			LAPIC_MODE_NMI		0x4
 #define			LAPIC_MODE_EXINT		0x7

To view, visit change 42454. To unsubscribe, or for help writing mail filters, visit settings.