[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/brox: Enable PMC pins to work with PD

[Ashish Kumar Mishra (Code Review)]

Attention is currently required from: Deepti Deshatty, Eric Lai, Shelley Chen, Varshit Pandya, Vijay P Hiremath.

Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81207?usp=email )

Change subject: mb/google/brox: Enable PMC pins to work with PD
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81207/comment/c668d2b2_208d4312 :
PS1, Line 9: For PMC-PD communication we need to enable 3 pins.
> this information for SoC (about native function) is captured in it's datasheet (EDS in your case), t […]

Done

File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:

https://review.coreboot.org/c/coreboot/+/81207/comment/09d572dc_e249ca07 :
PS2, Line 105: NC
> should remove NC?

Acknowledged

https://review.coreboot.org/c/coreboot/+/81207/comment/7690ae66_a36abb31 :
PS2, Line 137: NC
> same

Acknowledged

https://review.coreboot.org/c/coreboot/+/81207/comment/141141cf_03b89c70 :
PS2, Line 139: NC
> same

Acknowledged