[S] Change in coreboot[main]: mb/google/brox: Enable PMC pins to work with PD

Attention is currently required from: Deepti Deshatty, Eric Lai, Shelley Chen, Varshit Pandya, Vijay P Hiremath. Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81207?usp=email ) Change subject: mb/google/brox: Enable PMC pins to work with PD ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81207/comment/c668d2b2_208d4312 : PS1, Line 9: For PMC-PD communication we need to enable 3 pins.
this information for SoC (about native function) is captured in it's datasheet (EDS in your case), t […] Done
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/81207/comment/09d572dc_e249ca07 : PS2, Line 105: NC
should remove NC? Acknowledged
https://review.coreboot.org/c/coreboot/+/81207/comment/7690ae66_a36abb31 : PS2, Line 137: NC
same Acknowledged
https://review.coreboot.org/c/coreboot/+/81207/comment/141141cf_03b89c70 : PS2, Line 139: NC
same Acknowledged
-- To view, visit https://review.coreboot.org/c/coreboot/+/81207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia678d291e7a14aefe09026e70478fea3f68c8e10 Gerrit-Change-Number: 81207 Gerrit-PatchSet: 4 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra@intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty@intel.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Eric Lai <ericllai@google.com> Gerrit-CC: Varshit Pandya <pandyavarshit@gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit@gmail.com> Gerrit-Attention: Shelley Chen <shchen@google.com> Gerrit-Attention: Eric Lai <ericllai@google.com> Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath@intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty@intel.com> Gerrit-Comment-Date: Mon, 01 Apr 2024 04:01:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit@gmail.com> Comment-In-Reply-To: Ashish Kumar Mishra <ashish.k.mishra@intel.com> Comment-In-Reply-To: Eric Lai <ericllai@google.com> Comment-In-Reply-To: Deepti Deshatty <deepti.deshatty@intel.com> Gerrit-MessageType: comment
participants (1)
-
Ashish Kumar Mishra (Code Review)