Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )
Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46830/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46830/3/src/mainboard/google/voltee...
PS3, Line 122: ACPI_IRQ_LEVEL_LOW
It is still not clear to me if this change is correct. The device actually uses edge-triggered interrupts. Is this correct?
If yes, then I think we should identify if there are pulses shorter than 100us and fix that in the touchscreen firmware. Please see my comment on the partner issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d
Gerrit-Change-Number: 46830
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 30 Oct 2020 03:36:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment