Change in coreboot[master]: mb/google/volteer: Modify touchscreen IRQ to level trigger

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Casper Chang (Code Review)

27 Oct 2020 27 Oct '20

3:48 a.m.

Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

mb/google/volteer: Modify touchscreen IRQ to level trigger

Modify IRQ to level trigger to meet touchscreen device requirement.

BUG=b:170358155 TEST=Build Pass and test with vendor's latest touchscreen firmware

Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/46830/1

diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index 2db1f08..ba3f985 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -98,7 +98,7 @@ chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Casper Chang (Code Review)

27 Oct 27 Oct

3:50 a.m.

Casper Chang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

mb/google/volteer: Modify touchscreen IRQ to level trigger

Modify IRQ to level trigger to meet touchscreen device requirement.

BUG=b:170358155 TEST=Build Pass and test with vendor's latest touchscreen firmware.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/46830/2

Casper Chang (Code Review)

28 Oct 28 Oct

5:48 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 28 Oct 2020 04:48:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Casper Chang (Code Review)

5:49 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3:

Please kindly review this CL, the test is passed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 28 Oct 2020 04:49:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Scott Chao (Code Review)

6:55 a.m.

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 28 Oct 2020 05:55:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

30 Oct 30 Oct

4:36 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46830/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46830/3/src/mainboard/google/voltee... PS3, Line 122: ACPI_IRQ_LEVEL_LOW It is still not clear to me if this change is correct. The device actually uses edge-triggered interrupts. Is this correct?

If yes, then I think we should identify if there are pulses shorter than 100us and fix that in the touchscreen firmware. Please see my comment on the partner issue.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 30 Oct 2020 03:36:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Casper Chang (Code Review)

2 Nov 2 Nov

2:45 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46830/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46830/3/src/mainboard/google/voltee... PS3, Line 122: ACPI_IRQ_LEVEL_LOW

...

It is still not clear to me if this change is correct. […]

Thanks for the comment, we're seeking touchscreen vendor for more details about the setting.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Nov 2020 01:45:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Casper Chang (Code Review)

19 Nov 19 Nov

4:39 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3:

Hi Furquan,

Elan suggest to follow HID over I2C Protocol Specification[1] to updates the configuration of the HID over I2C devices to be level triggered.

Please kindly refer to the CL https://review.coreboot.org/c/coreboot/+/47421

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Nov 2020 03:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Casper Chang (Code Review)

6:28 a.m.

Casper Chang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Casper Chang (Code Review)

6:35 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46830 )

Change subject: mb/google/volteer: Modify touchscreen IRQ to level trigger ......................................................................

Patch Set 3:

Volteer variants already modified irq trigger methods in https://review.coreboot.org/c/coreboot/+/47416

Abandon this CL

Thanks a lot

-- To view, visit https://review.coreboot.org/c/coreboot/+/46830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30f6a43c2c783865e90264b6c7fcdc6002267a1d Gerrit-Change-Number: 46830 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Reviewer: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Nov 2020 05:35:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1264

days inactive

1287

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Casper Chang (Code Review)
Furquan Shaikh (Code Review)
Scott Chao (Code Review)