Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46267 )
Change subject: mb/intel/adlrvp: Add ADL-P mainboard ASL code ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46267/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46267/7//COMMIT_MSG@11 PS7, Line 11: Dump dsdt.aml and verified all ACPI device present there
Dump and disassemble DSDT and verify all ACPI devices are present.
Ack
https://review.coreboot.org/c/coreboot/+/46267/7/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46267/7/src/mainboard/intel/adlrvp/... PS7, Line 21: /* CPU */
I don't think this comment is useful
Ack
https://review.coreboot.org/c/coreboot/+/46267/7/src/mainboard/intel/adlrvp/... PS7, Line 24: Scope (_SB) { : Device (PCI0)
These two could be replaced with: […]
Ack