Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35744 )
Change subject: nb/intel/nehalem: Disable PEG and IGD based on devicetree
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35744/4/src/northbridge/intel/nehal...
File src/northbridge/intel/nehalem/northbridge.c:
https://review.coreboot.org/c/coreboot/+/35744/4/src/northbridge/intel/nehal...
PS4, Line 247: pci_write_config32(dev, D0F0_DEVEN, reg);
I don't like read-modify-write split like this for register D0F0_DEVEN, and having to re-initialise dev. I assume for this hardware there is no write-once registers involved?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35744
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib378458a55e18cc02fc49b3e6d6939d31dd4aa65
Gerrit-Change-Number: 35744
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Oct 2019 08:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment