Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46057 )
Change subject: soc/intel/xeon_sp: Use generic config_t ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46057/1//COMMIT_MSG@9 PS1, Line 9: Don't use the silicon specific typedef to get common config options. Technically, the only typedef here is config_t, which is not a pointer:
Don't use the silicon-specific struct type to get common config options. Instead, use the generic config_t typedef. This allows the function to be moved to common code in upcoming patches.