Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30554 )
Change subject: mb/qemu-riscv: update to match current qemu version ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Looks good (haven't tested it, though)
https://review.coreboot.org/#/c/30554/5/src/mainboard/emulation/qemu-riscv/K... File src/mainboard/emulation/qemu-riscv/Kconfig:
https://review.coreboot.org/#/c/30554/5/src/mainboard/emulation/qemu-riscv/K... PS5, Line 16: # util/riscv/make-spike-elf.sh build/coreboot.rom build/coreboot.elf Unnecessary, because we have Documentation/**/*.md
https://review.coreboot.org/#/c/30554/5/src/mainboard/emulation/qemu-riscv/u... File src/mainboard/emulation/qemu-riscv/uart.c:
https://review.coreboot.org/#/c/30554/5/src/mainboard/emulation/qemu-riscv/u... PS5, Line 21: : static uint8_t *buf = (void *)QEMU_VIRT_UART0; : uintptr_t uart_platform_base(int idx) : { : Could we use the common driver for memory-mapped 8250 here?