ron minnich has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37186 )
Change subject: Automatic firmware update
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
see my comments. it seems fine but it I can only +1.
https://review.coreboot.org/c/em100/+/37186/8/firmware.c
File firmware.c:
https://review.coreboot.org/c/em100/+/37186/8/firmware.c@224
PS8, Line 224: if (memcmp(name, "firmware/em100pro_fw_", 21))
This kind of thing scares me.
Could you
#define NAME "firmware/em100pro_fw_"
#define NAMElen strlen(NAME)
also ... memcmp? strncmp maybe?
https://review.coreboot.org/c/em100/+/37186/8/firmware.c@267
PS8, Line 267: if (!strncasecmp(filename, "auto", 5)) {
5? I think 4?
--
To view, visit
https://review.coreboot.org/c/em100/+/37186
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Iec7e640ee6a3574d1031a06d92d1cf5ebdd0da7f
Gerrit-Change-Number: 37186
Gerrit-PatchSet: 8
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Dec 2019 00:46:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
