see my comments. it seems fine but it I can only +1.

Patch set 8:Code-Review +1

View Change

2 comments:

• File firmware.c:

  • Patch Set #8, Line 224: if (memcmp(name, "firmware/em100pro_fw_", 21))

    This kind of thing scares me.
    Could you
    #define NAME "firmware/em100pro_fw_"
    #define NAMElen strlen(NAME)
    also ... memcmp? strncmp maybe?

  • Patch Set #8, Line 267: if (!strncasecmp(filename, "auto", 5)) {

    5? I think 4?

To view, visit change 37186. To unsubscribe, or for help writing mail filters, visit settings.