HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43706 )
Change subject: src/soc/amd: Add include <types.h> ......................................................................
Patch Set 1:
(5 comments)
I've dded some comments to make the review easy
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/common/block/in... PS1, Line 21: BIT(28) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/common/block/in... PS1, Line 25: BIT(30) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi_ctrl.c:
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/common/block/sp... PS1, Line 23: BIT(7) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/i2c.h:
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/picasso/include... PS1, Line 14: BIT(2) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/stoneyridge/inc... File src/soc/amd/stoneyridge/include/soc/i2c.h:
https://review.coreboot.org/c/coreboot/+/43706/1/src/soc/amd/stoneyridge/inc... PS1, Line 14: BIT(0) needs <types.h>