Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39187 )
Change subject: mb/emulation/qemu-armv7: Fix board ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-armv7/bootblock_asm.S:
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 37: msr cpsr_cxf, #0xdf Would suggest transitioning to Thumb immediately, like the default code.
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 38: You should call arm_init_caches somewhere. Better to standardize CPU init stuff in one function, and it turns the icache on for you which you want (assuming that even makes a difference on QEMU, not sure).
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 55: beq relocated This whole calling-_start-twice thing seems unnecessarily roundabout. Why not just make another function for the post-relocation entry point?
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 59: stmia r0!, {r9-r10} Why not just call memcpy()?
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 67: mov pc, lr nit: odd way to spell "bl lr"?
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 94: bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ cpu_info has been removed a long time ago. Where did you copy this stuff from?