Attention is currently required from: Nico Huber, Eugene Myers, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 183:
(10 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/6c64e276_f2139654 PS183, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/aba75072_4e7ff53e PS183, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/2e235f8c_049bc1be PS183, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/ec3803e0_a448453b PS183, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/4730b818_1f88fedc PS183, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/61c1c103_34f80bd1 PS183, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/d2b4eab5_6e28c231 PS183, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/ece6d6c5_869390ef PS183, Line 97: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/8df492a7_6bd0ed64 PS183, Line 120: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130360): https://review.coreboot.org/c/coreboot/+/35523/comment/ad013318_74dc213e PS183, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)