[coreboot-gerrit] Change in coreboot[master]: mb/acer: Add Acer Aspire VN7-572G

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )

Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................

Patch Set 158:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35523/145/src/mainboard/acer/aspire... 
File src/mainboard/acer/aspire_vn7_572g/gpio.h:

https://review.coreboot.org/c/coreboot/+/35523/145/src/mainboard/acer/aspire... 
PS145, Line 259: PAD_CFG_GPIO_BIDIRECT(GPP_E22, 0, NONE, DEEP, LEVEL, ACPI),
> I moved the macro into gpio. […]

AFAICT, enabling both tx and rx buffers does _not_ make a pad bidirectional.
Bidirectional is the sense of PROCHOT# means that all outputs connected to
the signal are hi-z by default and only when one of them wants to assert
the signal it pulls it (down likely). That would be the equivalent of enabling
a pad's tx buffer dynamically during runtime.