[coreboot-gerrit] Change in coreboot[master]: soc/intel: Use config_of_path(SA_DEVFN_ROOT)

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34299 )

Change subject: soc/intel: Use config_of_path(SA_DEVFN_ROOT)
......................................................................

Patch Set 4:
> Patch Set 4:
>
> (1 comment)
>
> Jacob, Elyes : Is one of you regularly running clang static analyzer passed?
>
> I wonder if it goes wild on this commit. My attempt here is to use __noreturn pcidev_die() called from inlined function. Is that enough / not required at all, to convince config_of() never returns with NULL.

Hi Kyösti, yes scan-build actually runs daily, you can see the results here if you like [0]. Making the function __noreturn should be enough to convince it that config_of() will never return with NULL. It's also probably a good thing to remove the extra checks that Furquan has pointed out, since otherwise Coverity will flag them as dead code (it's very clever).

[0] https://www.coreboot.org/scan-build/