Bhanu Prakash Maiya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44424 )
Change subject: mb/google/zork: Add helper function to read DB ID bits in FW_CONFIG
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/44424/1/src/mainboard/google/zork/v...
PS1, Line 150: return extract_field(FW_CONFIG_MASK_DB_INDEX, FW_CONFIG_DB_INDEX_SHIFT);
Need to use tab instead of spaces before "return ... […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3c882439bfbe6da28be2df0ec0c976d5c142677
Gerrit-Change-Number: 44424
Gerrit-PatchSet: 2
Gerrit-Owner: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 22:46:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment