Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )
Change subject: mb/google/zork/trembyle: update USB OC pin mapping
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG@12
PS1, Line 12: other
Which version? If we have different mapping per version, we should update the value of this pin at runtime. See https://review.coreboot.org/c/coreboot/+/44157/7 for an example.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6
Gerrit-Change-Number: 44268
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 06 Aug 2020 14:53:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment