Change in coreboot[master]: mb/google/zork/trembyle: update USB OC pin mapping

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Held (Code Review)

6 Aug 2020 6 Aug '20

9:46 a.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

mb/google/zork/trembyle: update USB OC pin mapping

The old USB OC pin mapping caused suspend to error out with an over- current condition on the USB ports. I found out that there are different versions of the schematics; this patch changes the mapping to the one found in the other version.

BUG=b:162912099

Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/zork/variants/trembyle/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/44268/1

diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index 26d9a3e..8b5c14f 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -24,8 +24,8 @@

# USB OC pin mapping register "usb_port_overcurrent_pin[0]" = "USB_OC_PIN_0" # USB C0 - register "usb_port_overcurrent_pin[1]" = "USB_OC_PIN_2" # USB A0 - register "usb_port_overcurrent_pin[2]" = "USB_OC_PIN_4" # USB A1 + register "usb_port_overcurrent_pin[1]" = "USB_OC_PIN_0" # USB A0 + register "usb_port_overcurrent_pin[2]" = "USB_OC_PIN_1" # USB A1 register "usb_port_overcurrent_pin[3]" = "USB_OC_PIN_1" # USB C1

# Enable I2C2 for trackpad, touchscreen, pen at 400kHz

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Felix Held (Code Review)

6 Aug 6 Aug

9:47 a.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1:

haven't tested this one, but verified with other version of the schematics

Raul Rangel (Code Review)

11:53 a.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG@12 PS1, Line 12: other Which version? If we have different mapping per version, we should update the value of this pin at runtime. See https://review.coreboot.org/c/coreboot/+/44157/7 for an example.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 14:53:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

11:55 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 14:55:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

12:02 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG@12 PS1, Line 12: other

...

Which version? If we have different mapping per version, we should update the value of this pin at r […]

I'm not sure if only the prototypes used 4 USB OC pins and if the EVT devices all only use 2 USB OC pins freeing up two pins for the WIFI/BT control. have a look at the two schematics I linked in the internal bug tracker; I'm not really sure which is which and if that's still relevant, since the support for the early prototypes is already dropped

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 15:02:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Gerrit-MessageType: comment

Aaron Durbin (Code Review)

12:09 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44268/1//COMMIT_MSG@12 PS1, Line 12: other

...

I'm not sure if only the prototypes used 4 USB OC pins and if the EVT devices all only use 2 USB OC […]

I responded on the bug itself. Let's clear things up there. Long and short of it is that there are no more builds for trembyle. I almost responded that we should be adjusting these pins dynamically based on board revision, but I'm not sure it's worth the hassle for this device. Felix, you can do that if you'd like or just put a comment that any potential future builds would need to address these differences.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 15:09:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel rrangel@chromium.org Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

Aaron Durbin (Code Review)

1:01 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1: -Code-Review

Something is amiss. This doesn't seem correct.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 16:01:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

7:46 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Patch Set 1:

We can abandon this one as there was a configuration issue.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 22:46:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

7 Aug 7 Aug

11:55 a.m.

Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44268 )

Change subject: mb/google/zork/trembyle: update USB OC pin mapping ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/44268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f24273ce486982b60f7927b0f9eb4a2c14cf0d6 Gerrit-Change-Number: 44268 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1391

days inactive

1392

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Aaron Durbin (Code Review)
Felix Held (Code Review)
Raul Rangel (Code Review)