1 Jul
2019
1 Jul
'19
3:51 a.m.
Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 14:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/33387/11/src/arch/arm64/armv8/cache.c File src/arch/arm64/armv8/cache.c:
https://review.coreboot.org/#/c/33387/11/src/arch/arm64/armv8/cache.c@a42 PS11, Line 42:
It will break as soon as someone else is trying to use BSS in the bootblock and isn't aware of this […]
OK. Thank you for your advice. I will revert this change and relocate BOOTBLOCK code into DRAM for the compatibility with other programs.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33387
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7c0831b1ecf08785b4ec8139d809bad9b3e1eec
Gerrit-Change-Number: 33387
Gerrit-PatchSet: 14
Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jul 2019 01:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Asami Doi d0iasm.pub@gmail.com
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment