Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )
Change subject: src/*: Make PCI ID macro names shorter
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
i like this change, since it shortens the names without losing information.
with the commands to do this in the commit message i don't think that it makes upstreaming and rebasing from older branches much more inconvenient than it would be without this patch.
to get this patch in master we need to coordinate things a bit; when other patches that use those defines are merged within the 24h cool-off window, this would need to be rebased over and over again. if we agree that this is a good idea, we should probably try to get the 3 +2 to fast-track this. since the patch has been sitting here for nearly two weeks, i'd find this approach acceptable here, even though this is not a "the tree is broken and we need to fix it asap" situation
https://review.coreboot.org/c/coreboot/+/39331/5/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
PS5:
since 6 chars get removed, the tab-alignement of the values is broken in some places. might be a bit annoying to fix, but currently this doesn't look too nice
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9027700f53b6d0d3964c26a41a1f9b8f62be178
Gerrit-Change-Number: 39331
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Mar 2020 18:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment