i like this change, since it shortens the names without losing information.
with the commands to do this in the commit message i don't think that it makes upstreaming and rebasing from older branches much more inconvenient than it would be without this patch.
to get this patch in master we need to coordinate things a bit; when other patches that use those defines are merged within the 24h cool-off window, this would need to be rebased over and over again. if we agree that this is a good idea, we should probably try to get the 3 +2 to fast-track this. since the patch has been sitting here for nearly two weeks, i'd find this approach acceptable here, even though this is not a "the tree is broken and we need to fix it asap" situation

Patch set 5:Code-Review +1

View Change

1 comment:

• File src/include/device/pci_ids.h:

  • Patch Set #5:

    since 6 chars get removed, the tab-alignement of the values is broken in some places. might be a bit annoying to fix, but currently this doesn't look too nice

To view, visit change 39331. To unsubscribe, or for help writing mail filters, visit settings.