Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/...
File src/mainboard/apple/macbookpro10_1/romstage.c:
https://review.coreboot.org/#/c/32673/22/src/mainboard/apple/macbookpro10_1/...
PS22, Line 82: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
Yes, it seems it was possible to buy version with 16G RAM soldered. […]
lenovo/x1_carbon_gen1 does that; IIRC also pcengines/apu2 and i think also some chromebooks.
I'd suggest having a look at the schematics if there are some resistors that tell the firmware what ram is soldered down.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32673
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df
Gerrit-Change-Number: 32673
Gerrit-PatchSet: 22
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 14:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment
