16 Sep
2020
16 Sep
'20
10:14 p.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45440 )
Change subject: util/mtkheader: Port gen-bl-img.py to python3 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45440/3/util/mtkheader/gen-bl-img.p... File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/45440/3/util/mtkheader/gen-bl-img.p... PS3, Line 1: #!/usr/bin/env python3
Can it be ported to be compatible with both Python versions?
I'd recommend keeping python3 specific, especially most other coreboot build scripts and also python3 now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45440
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I788e7c9b09257142728a0f76df8c2ccc72bf6b3b
Gerrit-Change-Number: 45440
Gerrit-PatchSet: 3
Gerrit-Owner: Yilin Yang kerker@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer reinauer@chromium.org
Gerrit-Comment-Date: Thu, 17 Sep 2020 01:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment