wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )
Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30974/5/src/soc/mediatek/mt8183/gpio.c File src/soc/mediatek/mt8183/gpio.c:
https://review.coreboot.org/#/c/30974/5/src/soc/mediatek/mt8183/gpio.c@77 PS5, Line 77: SCL0_EH
nit: maybe call them SCL0_EH_SHIFT/SCL0_RSEL_SHIFT to be clearer about what this is?
We would like to use a simple name here. If you like that way, we will modify it.
https://review.coreboot.org/#/c/30974/5/src/soc/mediatek/mt8183/gpio.c@109 PS5, Line 109: void gpio_set_i2c_eh_rsel(void)
Where are you calling this from? (I'd suggest bootblock_soc_init(). […]
https://review.coreboot.org/c/coreboot/+/30976/7/src/soc/mediatek/mt8183/mt8...