Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: add TX tracking for DRAM DVFS ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/Kco... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/Kco... PS8, Line 22: default y
Shouldn't change this.
I think this was changed so that Jenkins build-tests the change. This can also be achieved by adding a new file into `configs/` with this option enabled.
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2338: * I would also use spaces here
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2345: if (shu_src >= DRAM_DFS_SHUFFLE_MAX || shu_dst>= DRAM_DFS_SHUFFLE_MAX) {
Please fix this.
Note: Adding the extra space will make this line one character too long. Ouch :S
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2380: u4value = READ32_BITFIELD(&ch[chn].ao.shu[0].rk[rnk].selph_dqsg0, SHURK0_SELPH_DQSG0_TX_DLY_DQS0_GATED);
line over 96 characters
I would try to split these lines