Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37607 )
Change subject: superio/common/generic: Assign resources behind device ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37607/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37607/1//COMMIT_MSG@10 PS1, Line 10: need to scan the complete 'bus' even though it is not a bridge.
- There can be multiple siblings, we would need to reference one somehow (either in C or in ACPI) […]
I tried to find an example how the parent is accessed. There is none yet, right?
I have to admit, writing `"^^SMTH"` is easier than `"^^%s.SMTH", acpi_device_name(dev->...)`.
If we want hacks: It's possible to have a hierarchy in ASL but siblings in the devicetree: e.g. name the parent after the address "IO2E", and append that to the scope when writing the PNP devices.
If we don't want hacks: Please make this a proper bridge driver with .scan_bus and everything. assign_resources() is not the only thing missing here.