View Change
1 comment:
Commit Message:
Patch Set #1, Line 10: need to scan the complete 'bus' even though it is not a bridge.
1. There can be multiple siblings, we would need to reference one somehow (either in C or in ACPI) […]
I tried to find an example how the parent is accessed. There is none
yet, right?
I have to admit, writing `"^^SMTH"` is easier than `"^^%s.SMTH",
acpi_device_name(dev->...)`.
If we want hacks: It's possible to have a hierarchy in ASL but siblings
in the devicetree: e.g. name the parent after the address "IO2E", and
append that to the scope when writing the PNP devices.
If we don't want hacks: Please make this a proper bridge driver with
.scan_bus and everything. assign_resources() is not the only thing
missing here.
To view, visit change 37607. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id80a2ae6e82c151b8d8adc9c5f35f38362d538fa
Gerrit-Change-Number: 37607
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 09 Dec 2019 14:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment