Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 119:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 13: # TODO: select DRIVERS_NVIDIA_OPTIMUS more TODO
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 75: #config TPM_PIRQ : # hex : # default 0x1e # GPP_A6_IRQ remove if unused?
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 140: # TODO: register "PcieRpAspm[9]" = "ASPM_L1" : # TODO: register "PcieRpL1Substates[9]" = "L1_SS_DISABLED" lets resolve these TODOs (and the one above) is possible before merge
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 29: // #include "acpi/optimus_mb.asl" the file is in this patch, so is it just not working or?