Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede...
PS7, Line 12: |
nit: please align the "|"
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede...
PS7, Line 109: device pci 15.1 on
As I know, USI stylus and touchscreen controller are supported by I2C 2 and the pen detection here is not on I2C bus so why do we need to enable i2c 1 here?
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede...
PS7, Line 112: ACPI_GPIO_INPUT_ACTIVE_LOW
Wondering to know whether we should monitor both edge for pen inserted and ejected?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45807
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0
Gerrit-Change-Number: 45807
Gerrit-PatchSet: 7
Gerrit-Owner: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Kao
ben.kao@intel.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Oct 2020 13:13:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment