[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Support gpio eh and rsel setting for I2C

[wang qii (Code Review)]

wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )

Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c@98 
PS1, Line 98: 	MTK_I2C_PIN_SPEC(PAD_SDA4_ID, 17, 12),
> You didn't really answer my question. […]

Yes, if the default settings are not modified, i2c will not work under all speed conditions.