Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 66:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35523/65/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/35523/65/src/mainboard/acer/aspire_... PS65, Line 674: /* WBEC: Calls SMI function 0x11 */
Those SMI functions are not there on coreboot, are they?
No. I also think think that my assumption that 0x10-0x12 mapped to 0x80-0x82 (EC_WRITE is 0x81) was incorrect. The vendor implements a generic handler which receives 0x80-0x82 as well as 0x10 (from "RBEC" method).
These are possibly generic EC SCI commands? The KB9012QF datasheet, page 169, lists SCI events 0x10 and 0x11 for FAN0 and FAN1, as well as 0x12 for SMBus events.
I'm reverting this line until I can be sure what these do.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 170: x4
"Peg" usually refers to the PCIe lanes attached to the CPU, which do not exist on SKL-U
Hmm. In any case, if dGPUs are only PCIe devices on SKL-U, they wouldn't need any additional configuration/this is handled automatically.
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 240: device pci 01.0 on end # Dedicated Graphics Device Yes, but that's not what I meant. While 01:00.0 doesn't appear, coreboot doesn't remove Root Port 1, as it does the NGFF connector.
If the dGPU isn't present with coreboot, it is probably power gated because of Optimus.
I believe that Optimus only provides the OS a way to call BIOS functionality, through ACPI. It's clearly connected, but not the entire issue. However, perhaps if I look at the Optimus table, I'll see what I'm missing.
CB:39002 isn't related, is it? If Optimus on SKL-U doesn't have a PEG port, it wouldn't have a framebuffer, I imagine.