Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37490 )
Change subject: soc/amd/picasso: Add bootblock support ......................................................................
Patch Set 13: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi... File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi... PS13, Line 224: 0x10000 This is the same as the default value in src/arch/x86/Kconfig. Do you still need this here?
https://review.coreboot.org/c/coreboot/+/37490/11/src/soc/amd/picasso/Makefi... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37490/11/src/soc/amd/picasso/Makefi... PS11, Line 208: bootblock.elf
Let's leave the elf so we can extract the size later. […]
Sounds good.
https://review.coreboot.org/c/coreboot/+/37490/11/src/soc/amd/picasso/Makefi... PS11, Line 209: $(CONFIG_C_ENV_BOOTBLOCK_SIZE)
Yeah, but the file doesn't exist at the point this runs. […]
Sounds good.
https://review.coreboot.org/c/coreboot/+/37490/11/src/soc/amd/picasso/bootbl... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37490/11/src/soc/amd/picasso/bootbl... PS11, Line 6: #include <console/console.h>
We use a printk
That's right.