Patch set 13:Code-Review +2
4 comments:
File src/soc/amd/picasso/Kconfig:
Patch Set #13, Line 224: 0x10000
This is the same as the default value in src/arch/x86/Kconfig. Do you still need this here?
File src/soc/amd/picasso/Makefile.inc:
Patch Set #11, Line 208: bootblock.elf
Let's leave the elf so we can extract the size later. […]
Sounds good.
Patch Set #11, Line 209: $(CONFIG_C_ENV_BOOTBLOCK_SIZE)
Yeah, but the file doesn't exist at the point this runs. […]
Sounds good.
File src/soc/amd/picasso/bootblock/bootblock.c:
Patch Set #11, Line 6: #include <console/console.h>
We use a printk
That's right.
To view, visit change 37490. To unsubscribe, or for help writing mail filters, visit settings.