Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: [WIP] mb/asus/sklkbl_h: Add base for Asus Skylake Boards ......................................................................
Patch Set 23: Verified+1
(18 comments)
File src/mainboard/asus/sklkbl_h/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/34e38e10_aff0d200 PS23, Line 18: select SUPERIO_NUVOTON_COMMON_COM_A 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/76498d98_afea3aa2 PS23, Line 19: select SUPERIO_NUVOTON_NCT5539D 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/asus/sklkbl_h/Makefile.inc:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/0ccbc705_489d8268 PS23, Line 7: bootblock-y += variants/$(VARIANT_DIR)/superio.c 'superio' may be misspelled - perhaps ''?
File src/mainboard/asus/sklkbl_h/acpi/superio.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/6f3daaf2_9d2240e0 PS23, Line 3: #define SUPERIO_DEV SIO0 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/8c3347a3_95cdc199 PS23, Line 4: #define SUPERIO_PNP_BASE 0x2e 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/asus/sklkbl_h/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/e3d19a9b_e6bccedd PS23, Line 5: #include <variant/superio.h> 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/3840b3c3_27eb319b PS23, Line 10: variant_early_configure_superio(); 'superio' may be misspelled - perhaps ''?
File src/mainboard/asus/sklkbl_h/include/variant/superio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/6c8a6a89_1d137f2d PS23, Line 3: #ifndef MAINBOARD_SUPERIO_H 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/0284ec8d_032123bc PS23, Line 4: #define MAINBOARD_SUPERIO_H 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/cc975eea_816b6382 PS23, Line 6: void variant_early_configure_superio(void); 'superio' may be misspelled - perhaps ''?
File src/mainboard/asus/sklkbl_h/variants/h110t/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/e440cc5a_834ef901 PS23, Line 83: chip superio/common 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/11e4bff0_d62e1c2d PS23, Line 85: chip superio/nuvoton/nct5539d 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/918f8378_7f2fb4cc PS23, Line 152: end # superio/nuvoton/nct5539d 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/ff063b1d_f6b2d7e2 PS23, Line 154: end # superio/common 'superio' may be misspelled - perhaps ''?
File src/mainboard/asus/sklkbl_h/variants/h110t/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/b42fc56c_8f0b29ab PS23, Line 3: #include <superio/nuvoton/common/nuvoton.h> 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/3b924332_2407ac3c PS23, Line 4: #include <superio/nuvoton/nct5539d/nct5539d.h> 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/9c671df5_d8b093f1 PS23, Line 5: #include <variant/superio.h> 'superio' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348): https://review.coreboot.org/c/coreboot/+/48648/comment/1808736a_576ec9ba PS23, Line 7: void variant_early_configure_superio(void) 'superio' may be misspelled - perhaps ''?