Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons.

Patch set 23:Verified +1

View Change

18 comments:

• File src/mainboard/asus/sklkbl_h/Kconfig:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 18: select SUPERIO_NUVOTON_COMMON_COM_A

    'SUPERIO' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 19: select SUPERIO_NUVOTON_NCT5539D

    'SUPERIO' may be misspelled - perhaps ''?

• File src/mainboard/asus/sklkbl_h/Makefile.inc:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 7: bootblock-y += variants/$(VARIANT_DIR)/superio.c

    'superio' may be misspelled - perhaps ''?

• File src/mainboard/asus/sklkbl_h/acpi/superio.asl:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 3: #define SUPERIO_DEV SIO0

    'SUPERIO' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 4: #define SUPERIO_PNP_BASE 0x2e

    'SUPERIO' may be misspelled - perhaps ''?

• File src/mainboard/asus/sklkbl_h/bootblock.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 5: #include <variant/superio.h>

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 10: variant_early_configure_superio();

    'superio' may be misspelled - perhaps ''?

• File src/mainboard/asus/sklkbl_h/include/variant/superio.h:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 3: #ifndef MAINBOARD_SUPERIO_H

    'SUPERIO' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 4: #define MAINBOARD_SUPERIO_H

    'SUPERIO' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 6: void variant_early_configure_superio(void);

    'superio' may be misspelled - perhaps ''?

• File src/mainboard/asus/sklkbl_h/variants/h110t/devicetree.cb:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 83: chip superio/common

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 85: chip superio/nuvoton/nct5539d

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 152: end # superio/nuvoton/nct5539d

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 154: end # superio/common

    'superio' may be misspelled - perhaps ''?

• File src/mainboard/asus/sklkbl_h/variants/h110t/superio.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 3: #include <superio/nuvoton/common/nuvoton.h>

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 4: #include <superio/nuvoton/nct5539d/nct5539d.h>

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 5: #include <variant/superio.h>

    'superio' may be misspelled - perhaps ''?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-138348):

    Patch Set #23, Line 7: void variant_early_configure_superio(void)

    'superio' may be misspelled - perhaps ''?

To view, visit change 48648. To unsubscribe, or for help writing mail filters, visit settings.