build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )
Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................
Patch Set 1:
(20 comments)
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 181: acpigen_write_method("\_SB.BKEN", 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 182: acpigen_soc_clear_tx_gpio(GPIO_85); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 183: acpigen_pop_len(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 188: acpigen_write_method("\_SB.BKDS", 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 189: acpigen_soc_set_tx_gpio(GPIO_85); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 190: acpigen_pop_len(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 195: acpigen_write_method("\_SB.MINI", 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 196: acpigen_emit_namestring("\_SB.BKEN"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 197: acpigen_pop_len(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 202: acpigen_write_method("\_SB.MWAK", 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 203: acpigen_emit_namestring("\_SB.BKEN"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 204: acpigen_pop_len(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 209: acpigen_write_method("\_SB.MPTS", 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 210: acpigen_emit_namestring("\_SB.BKDS"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 211: acpigen_pop_len(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 216: mainboard_write_blken(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 217: mainboard_write_blkdis(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 218: mainboard_write_mini(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 219: mainboard_write_mpts(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 220: mainboard_write_mwak(); please, no spaces at the start of a line