Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38681 )
Change subject: mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method
......................................................................
Patch Set 3: Code-Review-1
I would prefer to untangle undock-button and power-supply events,
if that is possible. Also, the OS is responsible for decisions how
to act on the eject request and is the right place for user prefe-
rences. In case of Linux, it can be controlled with the `immediate_
undock` option of the `dock` module and from user space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38681
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I522ff7769267c88125397b7df75d313d92d5622f
Gerrit-Change-Number: 38681
Gerrit-PatchSet: 3
Gerrit-Owner: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Feb 2020 17:41:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment