Maccraft123 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38681 )
Change subject: mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method ......................................................................
mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method
Q50 Method can cause data loss in some circumstances, therefore I think there should be Kconfig option to disable it. EC triggers _Q50 when machine is docked and AC power supply is removed. If OS hasn't unmounted drive that is connected via USB or Ultrabay this behaviour causes data loss.
Change-Id: I522ff7769267c88125397b7df75d313d92d5622f Signed-off-by: Maciej Matuszczyk maccraft123mc@gmail.com --- M src/mainboard/lenovo/x201/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/38681/1
diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index a94d24e..3e83bdc 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -42,6 +42,15 @@ string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-rwa.fmd" if VBOOT
+config DISABLE_Q50 + bool "Disable _Q50 ACPI Method" + default n + help + This option disabled _Q50 Method that causes undock on removal of + AC power adapter. This behaviour can cause data loss by disconnecting + Ultrabay device without unmounting it first. + This option also disables the undock button on X200 Ultrabase. + config MAINBOARD_DIR string default "lenovo/x201"
Hello Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38681
to look at the new patch set (#2).
Change subject: mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method ......................................................................
mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method
Q50 Method can cause data loss in some circumstances, therefore I think there should be Kconfig option to disable it. EC triggers _Q50 when machine is docked and AC power supply is removed. If OS hasn't unmounted drive that is connected via USB or Ultrabay this behaviour causes data loss.
Change-Id: I522ff7769267c88125397b7df75d313d92d5622f Signed-off-by: Maciej Matuszczyk maccraft123mc@gmail.com --- M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x201/acpi/dock.asl 2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/38681/2
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38681
to look at the new patch set (#3).
Change subject: mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method ......................................................................
mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method
Q50 Method can cause data loss in some circumstances, therefore I think there should be Kconfig option to disable it. EC triggers _Q50 when machine is docked and AC power supply is removed. If OS hasn't unmounted drive that is connected via USB or Ultrabay this behaviour causes data loss.
Change-Id: I522ff7769267c88125397b7df75d313d92d5622f Signed-off-by: Maciej Matuszczyk maccraft123mc@gmail.com --- M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x201/acpi/dock.asl 2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/38681/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38681 )
Change subject: mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method ......................................................................
Patch Set 3: Code-Review-1
I would prefer to untangle undock-button and power-supply events, if that is possible. Also, the OS is responsible for decisions how to act on the eject request and is the right place for user prefe- rences. In case of Linux, it can be controlled with the `immediate_ undock` option of the `dock` module and from user space.
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38681?usp=email )
Change subject: mb/lenovo/x201: Kconfig option to disable Q50 ACPI Method ......................................................................
Abandoned
-
Maccraft123 (Code Review) -
Nico Huber (Code Review)
-
Stefan Reinauer (Code Review)