[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Support gpio eh and rsel setting for I2C

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )

Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30974/2/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/30974/2/src/soc/mediatek/mt8183/gpio.c@107 
PS2, Line 107: 	void *reg = GPIO_TO_IOCFG_BASE(gpio.base) + EH_RSEL_OFFSET;
> If I understand this right, there are a few EH_RSEL registers (one per IOCFG base) where all the EH  […]

Or is it important that only I2C bus pins get this setting, and pins that could be muxed to I2C but are doing something else on our board must not get it? Your code doesn't make any of this clear.