Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40946 )
Change subject: nb/intel/sandybridge/raminit: Add ECC debug code ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40946/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40946/1//COMMIT_MSG@12 PS1, Line 12: * ECC scrubbing must happen after dram_dimm_set_mapping()
Is this about the debug code?
No, the function enables the ECC logic to operate in normal mode. That is calculate the ECC bits and store them on write transaction.
https://review.coreboot.org/c/coreboot/+/40946/1//COMMIT_MSG@13 PS1, Line 13: * Move method out of try_init_dram_ddr3()
This is a result of the second point, right?
Yes. By coincidence this also satisfies the 2nd and 3rd point.