View Change
2 comments:
Commit Message:
Patch Set #1, Line 12: * ECC scrubbing must happen after dram_dimm_set_mapping()
Is this about the debug code?
No, the function enables the ECC logic to operate in normal mode. That is calculate the ECC bits and store them on write transaction.
Patch Set #1, Line 13: * Move method out of try_init_dram_ddr3()
This is a result of the second point, right?
Yes. By coincidence this also satisfies the 2nd and 3rd point.
To view, visit change 40946. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76174ec962c9b0bb72852897586eb95d896d301e
Gerrit-Change-Number: 40946
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Fri, 01 May 2020 17:38:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment