Attention is currently required from: Nico Huber, Eugene Myers, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 184:
(11 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/be660cc2_44c8ab63 PS184, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/3c47fac7_97d361a5 PS184, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/7eb6f04b_771fb915 PS184, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/2374467a_af238b3d PS184, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/69494205_dffbe55e PS184, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/0ee64139_0cedacdd PS184, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/5d2bc7b8_206edbc2 PS184, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/371a11d1_44753b7b PS184, Line 97: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/b475f74b_a0e73c14 PS184, Line 120: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/681e5419_42ec3cab PS184, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130361): https://review.coreboot.org/c/coreboot/+/35523/comment/86ee3b33_93b1f22b PS184, Line 159: if (gnvs) { braces {} are not necessary for single statement blocks