Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43006 )
Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................
mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition
There was a review comment for Chromium Linux ov2740 driver that Windows driver already set the HID as INT3474 and suggested to have the same value for Chrome.
The upstreamed Linux driver code has INT3474 as HID and this patch is to set the same HID in ACPI configuration.
https://patchwork.kernel.org/patch/11540753/
BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43006 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Daniel H Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 9f7b3e0..dad762a 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -495,7 +495,7 @@
Device (CAM1) { - Name (_HID, "OVTI2740") /* _HID: Hardware ID */ + Name (_HID, "INT3474") /* _HID: Hardware ID */ Name (_UID, Zero) /* _UID: Unique ID */ Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */