[coreboot-gerrit] Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 7:
> Patch Set 7:
>
> (2 comments)
> > Patch Set 5:
> > > Patch Set 5:
> > >
> > > That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.
> >
> > that sounds perfectly reasonable to me, thanks
>
> If one variant is SYSTEM_TYPE_LAPTOP, I would say SYSTEM_TYPE_DESKTOP is likely not the correct one for the other variants, assuming they have battery.
>
> Similarly, advertising PM_MOBILE for a unit that does have a battery seems wrong.
>
> Duncan? Any ideas

Ok.. So the entire SMBIOS_ENCLOSURE_TYPE is a bit of a mess, there will be followups on the topic. I have also discovered google/zork has fadt_pm_profile in devicetree.cb now.