Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47707 )
Change subject: mb/intel/ehlcrb: Add initial mainboard code
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart...
File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/gpio.c:
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart...
PS6, Line 20: return gpio_table;
I am doing it like that in my boards, for example clevo/cml-u. […]
Interesting. Seems nicer. I will look at your code and could add those changes after this (not in this patch, as this will serve as base codes). Thanks for this improvement!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cbe9f12468318680b148739edec5222582e42a0
Gerrit-Change-Number: 47707
Gerrit-PatchSet: 6
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Mon, 07 Dec 2020 15:20:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Lean Sheng Tan
lean.sheng.tan@intel.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment