Attention is currently required from: Martin Roth, Marshall Dawson, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48528 )
Change subject: soc/amd/cezanne: Add PSP integration for cezanne ......................................................................
Patch Set 34:
(6 comments)
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48528/comment/3e04c548_cbb83cdd PS29, Line 46: CONFIG_AMD_FWM_POSITION_INDEX
there should probably be a check to make sure that this isn't an empty string instead of the number […]
option1: write as 0$(CONFIG_AMD_FWM_POSITION_INDEX) option2: Give CONFIG_AMD_FWM_POSITION_INDEX a default value. Pushed as option2. For PCO, we need to check if it affects many boards.
https://review.coreboot.org/c/coreboot/+/48528/comment/4d0e3f43_f919db15 PS29, Line 113: OPT_APOB_ADDR=$(call add_opt_prefix, $(PSP_APOB_BASE), --apob-base)
the other apob related things aren't in here, so i wonder if this one should also be removed for now […]
Done. The amdfwtool requires this APOB base address need to be defined.
https://review.coreboot.org/c/coreboot/+/48528/comment/65c77929_7ec34dbe PS29, Line 137: $(OPT_SEC_DEBUG_FILE) \
this variable doesn't exist, so should probably be removed. […]
Done
https://review.coreboot.org/c/coreboot/+/48528/comment/d58bc22c_9693f0be PS29, Line 154: $(OPT_PSPBTLDR_FILE) \
this variable seems to be undefined, so i guess it can be removed. […]
Done
https://review.coreboot.org/c/coreboot/+/48528/comment/9849455e_14efb3a8 PS29, Line 156: $(OPT_VERSTAGE_FILE) \ : $(OPT_VERSTAGE_SIG_FILE) \
no verstage support yet, i'd remove those for now
Done
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48528/comment/ded225d2_8129414c PS34, Line 117: OPT_PSP_APCB_FILES= $(if $(APCB_SOURCES), --instance 0 --apcb $(APCB_SOURCES)) \ : $(if $(APCB_SOURCES_RECOVERY), --instance 10 --apcb $(APCB_SOURCES_RECOVERY)) \ : $(if $(APCB_SOURCES_68), --instance 18 --apcb $(APCB_SOURCES_68)) : PICASO uses $(if) to extract strings. It can handle the empty one.