Attention is currently required from: Martin Roth, Marshall Dawson, Felix Held.
6 comments:
File src/soc/amd/cezanne/Makefile.inc:
Patch Set #29, Line 46: CONFIG_AMD_FWM_POSITION_INDEX
there should probably be a check to make sure that this isn't an empty string instead of the number […]
option1: write as 0$(CONFIG_AMD_FWM_POSITION_INDEX)
option2: Give CONFIG_AMD_FWM_POSITION_INDEX a default value.
Pushed as option2. For PCO, we need to check if it affects many boards.
Patch Set #29, Line 113: OPT_APOB_ADDR=$(call add_opt_prefix, $(PSP_APOB_BASE), --apob-base)
the other apob related things aren't in here, so i wonder if this one should also be removed for now […]
Done.
The amdfwtool requires this APOB base address need to be defined.
Patch Set #29, Line 137: $(OPT_SEC_DEBUG_FILE) \
this variable doesn't exist, so should probably be removed. […]
Done
Patch Set #29, Line 154: $(OPT_PSPBTLDR_FILE) \
this variable seems to be undefined, so i guess it can be removed. […]
Done
$(OPT_VERSTAGE_FILE) \
$(OPT_VERSTAGE_SIG_FILE) \
no verstage support yet, i'd remove those for now
Done
File src/soc/amd/cezanne/Makefile.inc:
OPT_PSP_APCB_FILES= $(if $(APCB_SOURCES), --instance 0 --apcb $(APCB_SOURCES)) \
$(if $(APCB_SOURCES_RECOVERY), --instance 10 --apcb $(APCB_SOURCES_RECOVERY)) \
$(if $(APCB_SOURCES_68), --instance 18 --apcb $(APCB_SOURCES_68))
PICASO uses $(if) to extract strings. It can handle the empty one.
To view, visit change 48528. To unsubscribe, or for help writing mail filters, visit settings.