Name of user not set #1002873 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39894 )
Change subject: tests: Add build subsystem for unit testing coreboot ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39894/3/Makefile File Makefile:
https://review.coreboot.org/c/coreboot/+/39894/3/Makefile@171 PS3, Line 171: include $(DOTCONFIG)
Hmm... okay, fair enough, I see that there are some benefits to that (e.g. […]
As of now, I think it will be better to add some default variables into a Makefile, which can be overwritten by a cmdline provided along with "make unit-tests". This way we are isolating firmware build system from unit tests build system.
Will work on this in future.
https://review.coreboot.org/c/coreboot/+/39894/3/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39894/3/tests/Makefile.inc@58 PS3, Line 58: $$($(1)-stage)
Ack. […]
Good. After all, hopefully error message is clear and should be easy if one would like to change this const list.
https://review.coreboot.org/c/coreboot/+/39894/4/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39894/4/tests/Makefile.inc@54 PS4, Line 54: filter
nit: simpler with $(findstring)
Done